Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-55728) net-naming-scheme: disable NAMING_FIRMWARE_NODE_SUN #35

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

lnykryn
Copy link
Member

@lnykryn lnykryn commented Aug 22, 2024

No description provided.

rhel-only: policy
Related: RHEL-55728
It seems that virtio devices always have "0" in
the firmware_node/sun. And because of that, udev will
always name the device ens0, which leads to collisions.
So let's disable it for now.

rhel-only: policy
Resolves: RHEL-55728
@github-actions github-actions bot changed the title net-naming-scheme: disable NAMING_FIRMWARE_NODE_SUN (RHEL-55728) net-naming-scheme: disable NAMING_FIRMWARE_NODE_SUN Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

Commit validation

Tracker - RHEL-55728

The following commits meet all requirements

commit upstream
42bcbe1 - netif-naming-scheme: rename rhel-10.0 to rhel-10.0.beta rhel-only: policy
5aa6b6a - net-naming-scheme: disable NAMING_FIRMWARE_NODE_SUN rhel-only: policy
dbb084c - net-naming-scheme: remove NAMING_FIRMWARE_NODE_SUN from 9.5 rhel-only: policy

Tracker validation

Success

🟢 Tracker RHEL-55728 has set desired product: rhel-10.0
🟢 Tracker RHEL-55728 has set desired component: systemd
🟢 Tracker RHEL-55728 has been approved


Pull Request validation

Failed

🔴 Failed or pending checks - rpm-build:centos-stream-10-x86_64[failure],rpm-build:centos-stream-10-ppc64le[failure],rpm-build:centos-stream-10-aarch64[failure],rpm-build:centos-stream-10-s390x[in_progress],build (gcc, 13, mold, openssl)[in_progress],PR (undefined)[in_progress]

Success

🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved

rhel-only: policy
Resolves: RHEL-55728
Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lnykryn
Copy link
Member Author

lnykryn commented Aug 22, 2024

The build failures are expected. We need to tweak the specfile with rhel-10.0-beta naming policy

@lnykryn lnykryn merged commit 6a8e030 into redhat-plumbers:main Aug 22, 2024
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants