Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-30372) efi: check if all sections of our EFI binaries are properly aligned #248

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

(RHEL-30372) efi: check if all sections of our EFI binaries are properly aligned #248

wants to merge 3 commits into from

Commits on Jun 11, 2024

  1. efi: check if all sections of our EFI binaries are properly aligned 

    (cherry picked from commit 7ff3b88)

Related: RHEL-30372
    @mrc0mmand @jamacku
    mrc0mmand authored and jamacku committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4cfc409 View commit details
    Browse the repository at this point in the history

  2. ci: install pefile 

    (cherry picked from commit 1f6da5d)

Related: RHEL-30372
    @keszybz @jamacku
    keszybz authored and jamacku committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    bab9a56 View commit details
    Browse the repository at this point in the history

  3. efi: skip check-alignment-* tests if pefile is not installed 

    Otherwise, when building with ukify disabled, no one else requires pefile, and
if it is not installed, those tests fail:

```
================================== 12/1212 ===================================
test:         systemd:efi / check-alignment-systemd-bootx64.efi
start time:   14:21:54
duration:     0.08s
result:       exit status 1
command:      /mnt/work/systemd/upstream-fork/main/tools/check-efi-alignment.py /mnt/work/systemd/upstream-fork/main/build/src/boot/efi/systemd-bootx64.efi
----------------------------------- stderr -----------------------------------
Traceback (most recent call last):
  File "/mnt/work/systemd/upstream-fork/main/tools/check-efi-alignment.py", line 7, in <module>
    import pefile
ModuleNotFoundError: No module named 'pefile'
==============================================================================

================================== 13/1212 ===================================
test:         systemd:efi / check-alignment-linuxx64.efi.stub
start time:   14:21:54
duration:     0.08s
result:       exit status 1
command:      /mnt/work/systemd/upstream-fork/main/tools/check-efi-alignment.py /mnt/work/systemd/upstream-fork/main/build/src/boot/efi/linuxx64.efi.stub
----------------------------------- stderr -----------------------------------
Traceback (most recent call last):
  File "/mnt/work/systemd/upstream-fork/main/tools/check-efi-alignment.py", line 7, in <module>
    import pefile
ModuleNotFoundError: No module named 'pefile'
==============================================================================

================================== 14/1212 ===================================
test:         systemd:efi / check-alignment-addonx64.efi.stub
start time:   14:21:54
duration:     0.07s
result:       exit status 1
command:      /mnt/work/systemd/upstream-fork/main/tools/check-efi-alignment.py /mnt/work/systemd/upstream-fork/main/build/src/boot/efi/addonx64.efi.stub
----------------------------------- stderr -----------------------------------
Traceback (most recent call last):
  File "/mnt/work/systemd/upstream-fork/main/tools/check-efi-alignment.py", line 7, in <module>
    import pefile
ModuleNotFoundError: No module named 'pefile'
==============================================================================
```

Follow-up for 7ff3b88

(cherry picked from commit f0896ca)

Related: RHEL-30372
    @aafeijoo-suse @jamacku
    aafeijoo-suse authored and jamacku committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1abe8dc View commit details
    Browse the repository at this point in the history