Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome package #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Welcome package #52

wants to merge 2 commits into from

Conversation

IanTrudel
Copy link
Collaborator

  • New exciting background colour
  • ZSH is now installed and by default
  • Default xterm is sakura
  • A little banner to hype up InfiniteGlass

- New exciting background colour
- ZSH is now installed and by default
- Default xterm is sakura
- A little banner to hype up InfiniteGlass
@IanTrudel
Copy link
Collaborator Author

Feel free to adjust settings to your liking. :D

@redhog
Copy link
Owner

redhog commented Feb 24, 2020

This didn't work for me - I think you have some docker caching issues again, the keys used for ghosts are different since quite a while. I fixed that on this branch, but I still have a problem where Sakura doesn't seem to like being resized - it says it's 100x100px. Or maybe it's my code somehow... bug anyway :( Maybe a race condition?

@IanTrudel
Copy link
Collaborator Author

I did a make clean and a last test before sending a pull request to avoid such issues. If you have suggestions, I would take them!

@redhog
Copy link
Owner

redhog commented Feb 24, 2020

I think it might be time we change the docker image to just mount all of /InfiniteGlass from the outside, rather than have it in the image... It might cause some troubles with file permissions/ownership, but should mean that you never have version caching issues. What do you think?

@IanTrudel
Copy link
Collaborator Author

Yes, we should give this a try. It shouldn't be a problem for permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants