Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RS: Fix comment out swap partitions example #775

Merged
merged 3 commits into from
Dec 12, 2024
Merged

RS: Fix comment out swap partitions example #775

merged 3 commits into from
Dec 12, 2024

Conversation

rrelledge
Copy link
Collaborator

DOC-4028 and fixes #632

To test this fix:

  1. I ran the broken command with several different OS /etc/fstab example files, then confirmed that this command did not successfully comment out the swap partition entries.
  2. I ran the fixed command with several different OS /etc/fstab example files, then confirmed that swap partition entries were successfully commented out.

@rrelledge rrelledge added the rs Redis Enterprise Software label Oct 16, 2024
@rrelledge rrelledge requested review from adisht, maayanagranat and a team October 16, 2024 21:25
@rrelledge rrelledge self-assigned this Oct 16, 2024
Copy link
Contributor

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the sed(1) command locally; it works. LGTM.

@rrelledge rrelledge requested a review from bascar November 18, 2024 20:27
@rrelledge rrelledge merged commit 0b8663d into main Dec 12, 2024
5 checks passed
@rrelledge rrelledge deleted the DOC-4028 branch December 12, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rs Redis Enterprise Software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback: Configure swap for Linux
2 participants