Skip to content

DOC-4464 examples for llen, lpop, lpush, lrange, rpop, and rpush #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 28, 2025

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Jan 15, 2025

DOC-4464, DOC-4469, DOC-4474, DOC-4479, DOC-4489, and DOC-4484.

Go versions of the examples for LLEN, LPOP, LPUSH, LRANGE, RPOP, and RPUSH.

@andy-stark-redis andy-stark-redis self-assigned this Jan 15, 2025
@andy-stark-redis andy-stark-redis marked this pull request as ready for review January 15, 2025 13:54
@ndyakov ndyakov self-requested a review February 7, 2025 08:55
Copy link
Member

@ndyakov ndyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use better variable names for the examples.

@ndyakov
Copy link
Member

ndyakov commented Feb 21, 2025

@andy-stark-redis are we keeping those variable names or we are waiting for an update on this PR?

@andy-stark-redis
Copy link
Contributor Author

@andy-stark-redis are we keeping those variable names or we are waiting for an update on this PR?

@ndyakov I'll update them - I was just a little delayed in getting back to this.

@ndyakov ndyakov merged commit 53daf77 into redis:master Mar 28, 2025
16 checks passed
gh73962 pushed a commit to gh73962/go-redis that referenced this pull request Apr 3, 2025
…is#3234)

* DOC-4464 examples for llen, lpop, lpush, lrange, rpop, and rpush

* DOC-4464 improved variable names

---------

Co-authored-by: Vladyslav Vildanov <[email protected]>
Co-authored-by: Nedyalko Dyakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants