Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil pointer dereferencing in writeArg #3271

Merged
merged 13 commits into from
Feb 20, 2025
Merged

Conversation

aliforever
Copy link
Contributor

  • Added example for hset using struct
  • Added nil pointer checks to WriteArg (internal/proto/writer.go:62)
  • Added test cases

Issue: #3208

@ndyakov
Copy link
Collaborator

ndyakov commented Feb 10, 2025

Hello @aliforever, Looking at the example test, don't you think we should add a check with omitempty to verify the nil pointers will be retrieved as such? Other than that, lgtm. Maybe remove the dump package from the test so the linter passes? For some reason it doesn't like it. Will review once we have that test updated.

@aliforever
Copy link
Contributor Author

Hello @aliforever, Looking at the example test, don't you think we should add a check with omitempty to verify the nil pointers will be retrieved as such? Other than that, lgtm. Maybe remove the dump package from the test so the linter passes? For some reason it doesn't like it. Will review once we have that test updated.

Hi @ndyakov, I think linter was due to missing go.mod file in commit.

Regarding omitempty, I added it to a bool struct, is that what you meant?

@ndyakov
Copy link
Collaborator

ndyakov commented Feb 20, 2025

@aliforever yes, thank you. Will merge once CI completes.

@ndyakov ndyakov self-requested a review February 20, 2025 14:13
@ndyakov ndyakov added the bug label Feb 20, 2025
@ndyakov ndyakov merged commit 37accb4 into redis:master Feb 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants