Add integration tests for Redis 8 behavior changes in Redis Search #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndyakov
requested changes
Apr 7, 2025
There was a problem hiding this comment.
I don't think we should allow LIMIT 0 0 from the ft.search... We can introduce additional option to note that the execution should only count the results (and add LIMIT 0 0) but enabling it for all ft.search executions will break the default behaviour without setting the LimitOffset and Limit options since 0 is the default value for those integer. WDYT @ofekshenawa ?
ofekshenawa
force-pushed
the
os-test-behvioral-changes-in-search-on-redis-8
branch
from
5dd9515 to
ec1b320
Compare
…st-behvioral-changes-in-search-on-redis-8
ofekshenawa
force-pushed
the
os-test-behvioral-changes-in-search-on-redis-8
branch
from
51ec981 to
59e017e
Compare
|
blocked by #3338 |
…st-behvioral-changes-in-search-on-redis-8
ndyakov
reviewed
Apr 15, 2025
ndyakov
previously approved these changes
Apr 15, 2025
ndyakov
reviewed
Apr 16, 2025
ndyakov
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a suite of integration tests to validate the expected behavior changes and bug fixes introduced for Redisearch in Redis Community Edition 8. These tests cover several areas including query syntax, reducer default values, scoring defaults, alias validations, timeout behavior, and stop word handling.
IMPORTANT: This PR adds tests only to verify that the changes occur correctly. It does not implement any modifications to Redisearch itself.