Enforce code style format #4087
Open
+131
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ce6314a.
tishun
reviewed
Feb 7, 2025
| @@ -0,0 +1,68 @@ | |||
| name: Java Format Check | |||
There was a problem hiding this comment.
Do we need an additional action just for that? Could we do it as part of the integration?
If we keep it as a separate action it would do a lot of unnecessary new things - power up a container, fetch the contents of the PR, set Java up ...
| id: changed_files | ||
| run: | | ||
| echo "::group::Changed Java Files" | ||
| CHANGED_FILES=$(git diff --name-only origin/master | grep '\.java$' || true) |
There was a problem hiding this comment.
This is a bit brittle when we work with branches different than the main branch, we might want to add a parameter to indicate the branch we are merging to
| @@ -0,0 +1,37 @@ | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | |||
There was a problem hiding this comment.
How does having an additional pom.xml help in this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initiative to make the code formatting enforced on pipeline.
We will start with small steps and try to cover whole code base in multiple iterations.
The plan is step by step something like this (i guess this makes some sense as is, but lets improve the plan itself as well starting with this PR);
hbase-formatter.xmlas we see the opportunityformat_check.yml) to the pipeline to follow if the set of files in any PR is well formattedi think this approach will help us to cover more and more directories adding it into pom.xml. Later at some point we ll have full coverage and get rid of directories section in
pom.xml