fix: prevent blocking event loop thread by replacing ArrayDeque with HashIndexedQueue #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okg-cxf
changed the title
…g LinkedHashSetQueue instead of ArrayDeque for CommandHandler#stack
tishun
force-pushed
the
fix/avoid-long-block-during-disconnection
branch
from
d3662c0 to
c6f045c
Compare
|
@okg-cxf thanks for the contribution! I've enabled your solution by default. If there are issues with it we can ask users to disable it until we provide a fix. |
thachlp
pushed a commit
to thachlp/lettuce
that referenced
this pull request
Dec 31, 2024
…HashIndexedQueue (redis#2953) * fix: prevent long stall during reconnection/disconnection by providing LinkedHashSetQueue instead of ArrayDeque for CommandHandler#stack * Polishing * Missed out a file --------- Co-authored-by: Tihomir Mateev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2937
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.