Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2940 resubscribe ignoring sshardchannels backport to 6.4.x #3025

Closed
wants to merge 34 commits into from
Closed

2940 resubscribe ignoring sshardchannels backport to 6.4.x #3025

wants to merge 34 commits into from
+18,919 −3,392

Conversation

ggivo
Copy link
Contributor

@ggivo ggivo commented Oct 24, 2024

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

zeze1004 and others added 30 commits July 12, 2024 13:59
@zeze1004
[redis#2341] Initialize slots with empty BitSet in RedisClusterNode's…
dee8020 
… constructors (redis#2852)

* fix(redis#2341): Initialize slots with empty BitSet in RedisClusterNode's constructors

* test(redis#2341): Add test cases for slot initialization in RedisClusterNode constructors

* fix(redis#2341): Initialize RedisClusterNode slots with SlotHash.SLOT_COUNT

* chore(redis#2341): Adjust the formatting

* test(redis#2341):Add test cases for hasSameSlotsAs()

* fix(redis#2341): Clone node2 from node1 using the RedisClusterNode constructor and compare the two clusters with hasSameSlotsAs()
@tishun
Support the command (redis#2920)
666b4d7
@tishun
Add badges to the README.md file (redis#2939)
ec1dd41
@tishun
Suspected change in ubuntu (redis#2949)
53ba22b
@tishun
Add support for CLIENT TRACKINGINFO (redis#2862)
103636c 
* Initial commit

* Added the CLIENT TRACKINGINFO command

* Implement the final version of the command, add parser utility

* Add some more unit tests. Polishing.

* Implemented dynamic parsing of the result returned from CLIENT TRACKINGINFO

* Fixed conflixt issues

* Addressed Ali's comment on calling the .getDynamicMap only once

* Circle back to using domain objects

* Missed several crucial files

* Remove part of the license that is not needed
@dependabot
Bump org.jacoco:jacoco-maven-plugin from 0.8.9 to 0.8.12 (redis#2921)
7164552 
Bumps [org.jacoco:jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.9 to 0.8.12.
- [Release notes](https://github.com/jacoco/jacoco/releases)
- [Commits](jacoco/jacoco@v0.8.9...v0.8.12)

---
updated-dependencies:
- dependency-name: org.jacoco:jacoco-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump org.apache.maven.plugins:maven-surefire-plugin from 3.2.5 to 3.3…
cb73980 
….1 (redis#2922)

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.2.5 to 3.3.1.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.2.5...surefire-3.3.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump org.apache.maven.plugins:maven-failsafe-plugin from 3.2.5 to 3.3…
cce1aee 
….1 (redis#2958)

Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.2.5 to 3.3.1.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.2.5...surefire-3.3.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-failsafe-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.7.0 to 3.8.0 (
9495478 
redis#2957)

Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/apache/maven-javadoc-plugin/releases)
- [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.7.0...maven-javadoc-plugin-3.8.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-javadoc-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@uglide
Convert wiki to markdown docs (redis#2944)
c0e6993 
* Convert wiki to markdown docs

* Overhaul docs and fix obvious conversion issues

* Update docs workflow

* Fix links and include main README

* Update TLS section

* Fix more links

* Remove ascii docs and maven profile

* Fix spelling

* Build docs only from the main branch
@jkrauze
fix(2971): spublish typo fix (redis#2972)
c33cea9 
fixing redis#2971
@dependabot
Bump org.apache.maven.plugins:maven-surefire-plugin from 3.3.1 to 3.4…
3399252 
….0 (redis#2968)

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.3.1...surefire-3.4.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump org.hdrhistogram:HdrHistogram from 2.1.12 to 2.2.2 (redis#2966)
d3c8149 
Bumps [org.hdrhistogram:HdrHistogram](https://github.com/HdrHistogram/HdrHistogram) from 2.1.12 to 2.2.2.
- [Release notes](https://github.com/HdrHistogram/HdrHistogram/releases)
- [Commits](HdrHistogram/HdrHistogram@HdrHistogram-2.1.12...HdrHistogram-2.2.2)

---
updated-dependencies:
- dependency-name: org.hdrhistogram:HdrHistogram
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@thachlp
Update completeExceptionally on ClusterCommand using super (redis#2980)
c266570
@dependabot
Bump org.apache.maven.plugins:maven-compiler-plugin (redis#2978)
bfbb85f 
Bumps [org.apache.maven.plugins:maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.12.1 to 3.13.0.
- [Release notes](https://github.com/apache/maven-compiler-plugin/releases)
- [Commits](apache/maven-compiler-plugin@maven-compiler-plugin-3.12.1...maven-compiler-plugin-3.13.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-compiler-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Roiocam
fix:deadlock when reentrant exclusive lock redis#2905 redis#2879 (red…
bc84058 
…is#2961)

* fix:deadlock when reentrant exclusive lock redis#2905

* confirm won't blocking other thread

* apply suggestions
@thachlp
Default ClientOptions.timeoutOptions to TimeoutOptions.enabled() (red…
cf215de 
…is#2927)

* Default ClientOptions.timeoutOptions to TimeoutOptions.enabled()

* Update  ConnectionFailureIntegrationTests

* Update ClientOptionsIntegrationTests, RedisClusterSetupTest, AtMostOneceTest

* Update AtLeastOnceTest
@thachlp
Add support clusterlinks command (redis#2986)
c05da9e 
* Add support clusterlinks command

* Add test RedisCommandBuilderUnitTests
@dependabot
Bump org.apache.logging.log4j:log4j-bom from 2.17.2 to 2.24.0 (redis#…
acc94f8 
…2988)

Bumps [org.apache.logging.log4j:log4j-bom](https://github.com/apache/logging-log4j2) from 2.17.2 to 2.24.0.
- [Release notes](https://github.com/apache/logging-log4j2/releases)
- [Changelog](https://github.com/apache/logging-log4j2/blob/2.x/RELEASE-NOTES.adoc)
- [Commits](apache/logging-log4j2@rel/2.17.2...rel/2.24.0)

---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jinkshower @tishun
Add defensive copy for Futures allOf() method (redis#2943)
bf5bd75 
* Add defensive copy

Closes redis#2935

* Polishing

* Forgot to call formatter, shame on me

---------

Co-authored-by: Tihomir Mateev <[email protected]>
@dependabot
Bump io.netty:netty-bom from 4.1.107.Final to 4.1.113.Final (redis#2990)
2267bfe 
Bumps [io.netty:netty-bom](https://github.com/netty/netty) from 4.1.107.Final to 4.1.113.Final.
- [Commits](netty/netty@netty-4.1.107.Final...netty-4.1.113.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tishun
Introducing JSON to Lettuce (redis#2933) (redis#2992)
547271c 
* Most of the API layer

* Add the JSON.TYPE command

* Kotlin coroutines added;
Started JSON README.md;
Parser registry is now part of the Connection;
formatting;
chained all commands;
extracted commands in their own unit RedisJsonCommandBuilder;

* Implemented 90% of commands from top 10

* All but SET are implemented

* Integrated Jackson, finished up the SET command

* Left out a few files by mistake

* Adding some JavaDoc

* Formatting

* Implemented all JSON commands

* Introducing test containers to the testing fw

* Complete coverage with integration tests, straight scenarios

* Added Pathv1 tests

* Added RedisCE cluster support for the JSON.MGET and JSON.MSET commands

* Handle null values

* No longer using K for the JSON object keys

* Polishing

* JsonType introduced to help typization

* Remove the RedisCodec from the JsonValue/JsonParser abstraction, add configuration for custom parsers

* Extend API surface with methods that reduce the amount of required arguments

* Adding unit tests, addressing changes to README.md

* Implemented object-mapping functionality

* Addresses Ali's comments

* Addressed last bunch of comments from Ali, changed ports to not colide with existing infra

* Forgot to change ports and stop debug log

* Polishing touches
@tishun
Bits and pieces to clean up (redis#2995)
41b2b1f 
* Cleaning some leftovers

* Added a exceptions for RedisJson and MkDocs to the allowed words list
@joshrotenberg
add the github repo url to the doc config (redis#3008)
9185a49
@thachlp
Propagate database number, user, and RedisURI into Tracing (redis#3005)
542b6a5 
* Propagate database number, user, and RedisURI into Tracing

* Update attribute names as recommend

* Add db.user info

* Polishing
@tishun
ClassNotFoundException: com.fasterxml.jackson.core.JsonProcessingExce…
d255b1a 
…ption (2993) (redis#2997)

* Load the Jackson-based implementation dynamically to avoid ClassNotFound

* Complete the chanegs to the RELEASE-NOTES.MD

* Extend list of exceptions

* Tweaks to the presentation of the ne JSON guide

* Behavior is the preferred spelling in American English. Behaviour is preferred everywhere else. Extending list of exceptions to include (most) cases of the usage.

* Use the release version for the badge

* Lazy initialize the JsonParser instance to avoid hitting NoClassDefFound error

* Shame (ding) shame (ding) shame (ding)

* Yet more words to add to the wordlist
@nosan
Add support for creating regex and subnet-based ReadFrom instances fr…
8fc5a3f 
…om a single string redis#3013 (redis#3016)

Before this commit, it was not possible to use ReadFrom.valueOf(name) for subnet and regex types.
This commit introduces a new syntax subnet:192.168.0.0/16,2001:db8:abcd:0000::/52 and regex:.*region-1.* respectively
@wmxl
Add hasNoSlots() method to RedisClusterNode (redis#3015)
f467212
@tishun
Initialize with -1 to avoid hitting the sizing issue (redis#3020)
aec0887
@tishun
Improvements to the testing bits (redis#3012)
1de2116 
* Use tags for tests identification

* Remove imports that are not needed
winguse and others added 4 commits October 18, 2024 21:28
@winguse
document update regarding addressResolverGroup settings (redis#3007)
459d4ea 
* Update advanced-usage.md

* update doc

* update doc

* pr comments (sorry for getting back late)

* wrap with actual DnsAddressResolverGroup

* use space
@jabolina
fix: Lcs response parse (redis#2970)
3702373 
* fix: Lcs response parse

* Handle parsing `len` and `matches` in any order;

* Increase test coverage

* Add more unit tests to handle the different cases;
* Add integration tests when the `LCS` command is available;
* Update the StringMatchResultOutput to avoid keeping track of withIdx
  parameter. This allows the use in the command factory.
@tishun
Add CodeCov configuration, enable test analytics (redis#3022) (redis#…
29afe13 
…3023)

* Add CodeCov configuration, enable test analytics

* Issue in argument

* ... and the right filename

* ... perhaps by specifying exactly where the file is?

* Polishing

* Check why configuration is not working

* Final version
@ggivo
Closes redis#2940 Sharded PubSub subscriptions not recovered after di…
f4e7242 
…sconnection and re-connection.
@ggivo ggivo changed the title 2940 resubscribe ignoring sshardchannels 6 4 0 2940 resubscribe ignoring sshardchannels backport to 6.4.x Oct 24, 2024
@ggivo ggivo closed this Oct 24, 2024
@ggivo ggivo deleted the 2940-resubscribe-ignoring-sshardchannels-6_4_0 branch October 24, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.