Deprecate the STRALGO command and implement the LCS in its place

[Dltmd202]

Deprecate the STRALGO command and implement the LCS in its place

Is your feature request related to a problem? Please describe
With redis/redis#9744 the STRALGO command was deprecated in Redis 7.0
Tests that test the STRALGO command have not been running since the pipeline only uses latest Redis versions

Describe the solution you'd like
Implement the LCS command

Describe alternatives you've considered
For users of the Lettuce driver the only possible solution now is to use the Custom commands

Closes #2987

Make sure that:

• You have read the contribution guidelines.
• You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
• You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
• You submit test cases (unit or integration tests) that back your changes.

[tishun]

Hey folks, there seem to be test failures, could you check locally if tests pass?

make test

[Dltmd202]

I'm really sorry.
I thought all I had to do was mvn test, I would test it, edit the code, and upload it quickly.

[Dltmd202]

@tishun I modified the code to make the integration test run successfully!

[tishun]

Hey, apologies for the late response, there are a few things that are missing I am afraid.

You can get some ideas from the original PR that introduced STRALGO, but in short:

• we use a template file to generate the different commands, in this case the src/main/templates/io/lettuce/core/api/RedisStringCommands.java, after adding the new command there you can call the tests in the src/test/java/io/lettuce/apigenerator to generate the different methods in all related classes. You can comment out the other commands in the "Constants" class to avoid generating anything else but the RedisStringCommands.

[Dltmd202]

I realized through the template file (src/main/templates/io/lettuce/core/api/RedisStringCommands.java) how it determines the implementation of various connection methods, like reactor and async.

Additionally, I noticed I had missed the NodeSelection series, so I registered that part as well and re-uploaded the code.

Thank you so much for your review @tishun!

[tishun]

I realized through the template file (src/main/templates/io/lettuce/core/api/RedisStringCommands.java) how it determines the implementation of various connection methods, like reactor and async.

Additionally, I noticed I had missed the NodeSelection series, so I registered that part as well and re-uploaded the code.

Thank you so much for your review @tishun!

If you run the apigenerator test cases they would generate all the required API changes.

Then all you have to do is wire the implementation in.

[tishun]

Looks awesome, thanks for the contribution!