docs: update the default credential provider for more efficient credentials #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobymicroby
requested changes
Apr 2, 2025
packages/entraid/README.md
Outdated
|
|
||
| // Create a DefaultAzureCredential instance | ||
| const credential = new DefaultAzureCredential(); | ||
| const credential = new getDefaultAzureCredential(); |
There was a problem hiding this comment.
I think you forgot to remove ‘new’ ;
Have you tested the snippet? What is the difference between using constructor and ‘getDefaultAzureCredential’ ?
There was a problem hiding this comment.
Whoops, yes. I'll update this when I'm back at my computer
dhensby
force-pushed
the
pulls/entra-docs
branch
from
f0f7428 to
bb39631
Compare
bobymicroby
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor update to the @redis/entraid package to include a more efficient way to create the default credential, as well as updating the current version of the library that needs to be used.
Checklist
npm testpass with this change (including linting)?