-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement count function #336
base: main
Are you sure you want to change the base?
Conversation
8b6fe19
to
688db86
Compare
Signed-off-by: wiseaidev <[email protected]>
Signed-off-by: wiseaidev <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #336 +/- ##
==========================================
- Coverage 77.25% 77.12% -0.14%
==========================================
Files 12 12
Lines 1165 1154 -11
==========================================
- Hits 900 890 -10
+ Misses 265 264 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: wiseaidev <[email protected]>
@dvora-h, this PR is ready for reviews! |
Missed this in the GH notifications. Looking today there's an implementation of count. This would change that implementation. IMHO we should combine the ideas. Yours uses a batch size, which can be more performant based on data types (great)! though it should make use of DEFAULT_PAGE_SIZE for the batch argument, much like all. WDYT @wiseaidev? |
Related to #283
Implemented as described here. I think I forget to implement the second one with
FILTER
. It seems like we don't have to passFILTER
in args cause it will work the same as passing multiple fields.Note that passing
LIMIT 0 0
into the query will not work as described in the docs, it will throw an exception. It seems like the docs are outdated or something. The default valueLIMIT 0 10
works.