Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hint Lock.extend's additional_time as a Number #3522

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

Perlence
Copy link
Contributor

@Perlence Perlence commented Feb 21, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

It must be possible for the function to receive floats, as the docstring and the code suggest.

It must be possible for the function to receive floats, as the docstring
and the code suggest.
@Perlence Perlence force-pushed the fix-lock-extend-param-typing branch from d467186 to e080b9b Compare February 21, 2025 08:36
@Perlence Perlence changed the title Type hint Lock.extend's additional_time as a float Type hint Lock.extend's additional_time as a Number Feb 21, 2025
Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@petyaslavova petyaslavova merged commit 75cac31 into redis:master Feb 21, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants