Skip to content

Commit

Permalink
gha: remove hard-coded dockerhub username
Browse files Browse the repository at this point in the history
Change the secret being fetched by a new one that is named following our
secret naming guidelines

In addition, remove hard-coded username to allow easy change in the
future of this value
  • Loading branch information
ivotron committed Nov 9, 2024
1 parent 1260ede commit 3a6b498
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: aws-actions/aws-secretsmanager-get-secrets@v2
with:
secret-ids: |
,sdlc/prod/github/dockerhub_token
,sdlc/prod/github/dockerhub
parse-json-secrets: true
- uses: actions/checkout@v4
- uses: docker/setup-qemu-action@v3
Expand All @@ -45,7 +45,7 @@ jobs:
type=semver,pattern={{raw}}
- uses: docker/login-action@v3
with:
username: vectorizedbot
username: ${{ env.DOCKERHUB_USER }}
password: ${{ env.DOCKERHUB_TOKEN }}
- uses: docker/build-push-action@v6
with:
Expand Down

0 comments on commit 3a6b498

Please sign in to comment.