Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fio): remove fio wrapper #158

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

NaddiNadja
Copy link
Contributor

Removing the fio wrapper, as it is not necessary anymore. This will solve point 2 in #124

@NaddiNadja NaddiNadja force-pushed the fio-wrapper branch 3 times, most recently from ac2973b to 3f4a70f Compare February 10, 2025 14:59
Signed-off-by: Nadja Brix Koch <[email protected]>
Copy link
Collaborator

@safl safl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@safl safl merged commit f0f08ef into refenv:main Feb 10, 2025
20 checks passed
@safl safl added this to the v1.0.0 milestone Feb 10, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13243890383

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 64.642%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/cijoe/fio/scripts/check.py 4 6 66.67%
Totals Coverage Status
Change from base Build 13200870279: -0.04%
Covered Lines: 1179
Relevant Lines: 1872

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants