Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Ant Design's mobile sider doesn't change placement in RTL direction #6263

Closed
aliemir opened this issue Aug 16, 2024 · 0 comments · Fixed by #6245 or #6253
Closed

[BUG] Ant Design's mobile sider doesn't change placement in RTL direction #6263

aliemir opened this issue Aug 16, 2024 · 0 comments · Fixed by #6245 or #6253
Assignees
@aliemir
Labels
bug Something isn't working
Milestone
September Release

Comments

@aliemir
Copy link
Member

aliemir commented Aug 16, 2024

Describe the bug

While @refinedev/antd's <ThemedLayoutV2 /> has RTL support for the sider and it works well but in mobile sider the placement is not respecting the changes in direction. Styling of the drawer trigger is also not updated with direction changes.

localhost_5173_posts_pageSize=10 current=1

Steps To Reproduce

  1. Set up a Refine + Ant Design app
  2. Wrap the app with <ConfigProvider /> and pass direction="rtl"
  3. On small screen sizes, observe the drawer and the trigger is not placed properly (check above screenshot)

Expected behavior

When direction is set to "rtl" drawer and the trigger should be placed properly.

Packages

  • @refinedev/antd

Additional Context

No response
@aliemir aliemir added the bug Something isn't working label Aug 16, 2024
@aliemir aliemir added this to the September Release milestone Aug 16, 2024
@aliemir aliemir linked a pull request Aug 16, 2024 that will close this issue
fix(antd): rtl support for mobile sider #6245
Merged
5 tasks
@aliemir aliemir mentioned this issue Aug 16, 2024
Merged
5 tasks
@aliemir aliemir self-assigned this Aug 19, 2024
@BatuhanW BatuhanW linked a pull request Sep 2, 2024 that will close this issue
release: september 2024 #6253
Merged
@refine-bot refine-bot mentioned this issue Sep 3, 2024
Merged
emrecancorapci pushed a commit to emrecancorapci/refine that referenced this issue Sep 4, 2024
@youssefsiam38 @aliemir @emrecancorapci
fix(antd): rtl support for mobile sider (refinedev#6245) (fixes refin…
74bc6ea 
…edev#6263)

Co-authored-by: Ali Emir Şen <[email protected]>
emrecancorapci pushed a commit to emrecancorapci/refine that referenced this issue Sep 4, 2024
@youssefsiam38 @aliemir @emrecancorapci
fix(antd): rtl support for mobile sider (refinedev#6245) (fixes refin…
45983cf 
…edev#6263)

Co-authored-by: Ali Emir Şen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aliemir aliemir

Labels
bug Something isn't working
Projects
None yet
Milestone
September Release
1 participant
@aliemir