-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(antd): rtl support for mobile sider #6245
Conversation
🦋 Changeset detectedLatest commit: cf39381 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @youssefsiam38,
Thanks for the PR! A few things need fixing:
- Please open an issue so we can understand the problem and how your PR solves it. This helps us and others track it easily.
- We need a changeset to publish a new version.
- Use conventional commit messages for clarity.
Everything else looks good. Feel free to ask if you have any questions!
ce864cd
to
6963e59
Compare
…edev#6263) Co-authored-by: Ali Emir Şen <[email protected]>
…edev#6263) Co-authored-by: Ali Emir Şen <[email protected]>
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
Changes
<ThemedLayoutV2 />
has RTL support but it lacks the mobile sider trigger and drawer placement. This change places the drawer depending on the preferred direction. It also adds RTL support for the styling of the mobile sider trigger.Fixes #6263