Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(antd): rtl support for mobile sider #6245

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

youssefsiam38
Copy link
Contributor

@youssefsiam38 youssefsiam38 commented Aug 10, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

Changes

<ThemedLayoutV2 /> has RTL support but it lacks the mobile sider trigger and drawer placement. This change places the drawer depending on the preferred direction. It also adds RTL support for the styling of the mobile sider trigger.

Fixes #6263

@youssefsiam38 youssefsiam38 requested a review from a team as a code owner August 10, 2024 01:31
Copy link

changeset-bot bot commented Aug 10, 2024

🦋 Changeset detected

Latest commit: cf39381

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@refinedev/antd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@youssefsiam38 youssefsiam38 changed the title Add rtl support to antd sider Add rtl support to antd drawer sider Aug 10, 2024
@aliemir aliemir added this to the September Release milestone Aug 13, 2024
Copy link
Member

@alicanerdurmaz alicanerdurmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @youssefsiam38,

Thanks for the PR! A few things need fixing:

  • Please open an issue so we can understand the problem and how your PR solves it. This helps us and others track it easily.
  • We need a changeset to publish a new version.
  • Use conventional commit messages for clarity.

Everything else looks good. Feel free to ask if you have any questions!

@aliemir aliemir changed the base branch from master to releases/september August 13, 2024 14:57
@aliemir aliemir changed the title Add rtl support to antd drawer sider fix(antd): rtl support for mobile sider Aug 13, 2024
@aliemir aliemir self-assigned this Aug 16, 2024
@aliemir aliemir merged commit 7ba4ea1 into refinedev:releases/september Aug 16, 2024
11 of 12 checks passed
@aliemir aliemir mentioned this pull request Aug 16, 2024
emrecancorapci pushed a commit to emrecancorapci/refine that referenced this pull request Sep 4, 2024
emrecancorapci pushed a commit to emrecancorapci/refine that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Ant Design's mobile sider doesn't change placement in RTL direction
3 participants