Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@refinedev/cli): add "--platform" option to specify project type #4833

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

mikeyfarina
Copy link
Contributor

@mikeyfarina mikeyfarina commented Aug 16, 2023

Adds CLI option to specify platform to run refine on

Closing issues

closes #4795

Self Check before Merge

Please check all items below before review.

  • Corresponding issues are created/updated or not needed
  • Docs are updated/provided or not needed
  • Examples are updated/provided or not needed
  • TypeScript definitions are updated/provided or not needed
  • Tests are updated/provided or not needed
  • Changesets are provided or not needed

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

🦋 Changeset detected

Latest commit: 1f141b0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for aquamarine-panda-e208bf ready!

Name Link
🔨 Latest commit 1f141b0
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-panda-e208bf/deploys/64dea5117335ce00087d629f
😎 Deploy Preview https://deploy-preview-4833--aquamarine-panda-e208bf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for lighthearted-pastelito-e86ad1 ready!

Name Link
🔨 Latest commit 1f141b0
🔍 Latest deploy log https://app.netlify.com/sites/lighthearted-pastelito-e86ad1/deploys/64dea51118d52f00085b5ed3
😎 Deploy Preview https://deploy-preview-4833--lighthearted-pastelito-e86ad1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for imaginative-sundae-1fd394 ready!

Name Link
🔨 Latest commit 1f141b0
🔍 Latest deploy log https://app.netlify.com/sites/imaginative-sundae-1fd394/deploys/64dea5113e48510008b1ac9a
😎 Deploy Preview https://deploy-preview-4833--imaginative-sundae-1fd394.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for zippy-semolina-4ad81e ready!

Name Link
🔨 Latest commit 1f141b0
🔍 Latest deploy log https://app.netlify.com/sites/zippy-semolina-4ad81e/deploys/64dea511f8357a0008b50083
😎 Deploy Preview https://deploy-preview-4833--zippy-semolina-4ad81e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for refine-doc-live-previews ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1f141b0
🔍 Latest deploy log https://app.netlify.com/sites/refine-doc-live-previews/deploys/64dea5119bbf580008edcd22
😎 Deploy Preview https://deploy-preview-4833--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for stupendous-taffy-33f80c ready!

Name Link
🔨 Latest commit 1f141b0
🔍 Latest deploy log https://app.netlify.com/sites/stupendous-taffy-33f80c/deploys/64dea5119dc1b80009c3eea1
😎 Deploy Preview https://deploy-preview-4833--stupendous-taffy-33f80c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MahirMahdi
Copy link
Contributor

closes #4795

Copy link
Contributor

@MahirMahdi MahirMahdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mikeyfarina
Copy link
Contributor Author

@MahirMahdi Thank you for the review!

@aliemir
Copy link
Member

aliemir commented Aug 17, 2023

Hey @mikeyfarina thank you for the PR! 🚀 I'll review & test it soon. @MahirMahdi thank you for the review ❤️

@MahirMahdi
Copy link
Contributor

@aliemir anytime ❤️

@mikeyfarina
Copy link
Contributor Author

@aliemir @MahirMahdi Hi guys 😁 anything i can do to help get this pr into a state that I can use it in my other repo?

@MahirMahdi
Copy link
Contributor

@mikeyfarina I guess you need to wait until it gets merged.

@aliemir aliemir added this pull request to the merge queue Aug 22, 2023
Merged via the queue into refinedev:next with commit 9a24e46 Aug 22, 2023
37 of 38 checks passed
@nx-cloud
Copy link

nx-cloud bot commented Aug 22, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1f141b0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 83 targets

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Ability to specify which react platform to run cli commands on
4 participants