feat(core): add onUnauthorized callback to <CanAccess /> component
#4906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4bc3073 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stupendous-taffy-33f80c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4bc3073. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
alicanerdurmaz
force-pushed
the
ref-38-can-access-should-accept-onUnauthorized-callback
branch
from
60a5432
to
c79065f
Compare
✅ Deploy Preview for aquamarine-panda-e208bf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for imaginative-sundae-1fd394 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zippy-semolina-4ad81e ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for lighthearted-pastelito-e86ad1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aliemir
approved these changes
Sep 4, 2023
BatuhanW
reviewed
Sep 5, 2023
BatuhanW
reviewed
Sep 5, 2023
BatuhanW
approved these changes
Sep 5, 2023
|
|
||
| import { useCan, useResource } from "@hooks"; | ||
| import { BaseKey, IResourceItem, ITreeMenu } from "../../interfaces"; | ||
|
|
||
| type Params = { |
There was a problem hiding this comment.
I think this name is too generic. Optionally, we can rename it to something more specific, so it will be easier to read.
BatuhanW
approved these changes
Sep 6, 2023
salihozdemir
approved these changes
Sep 11, 2023
Co-authored-by: Salih Özdemir <[email protected]>
omeraplak
deleted the
ref-38-can-access-should-accept-onUnauthorized-callback
branch
This was referenced Sep 12, 2023
MahirMahdi
pushed a commit
to MahirMahdi/refine
that referenced
this pull request
Sep 16, 2023
refinedev#4906) * feat(core): add onUnauthorized callback to CanAccess component * chore(core): changeset * chore(core): refactor inline types to type * chore(core): use only can state on effect dependencies * test(core): test callback only trigger once * chore(core): change type name * chore: typo fix Co-authored-by: Salih Özdemir <[email protected]> --------- Co-authored-by: Batuhan Wilhelm <[email protected]> Co-authored-by: Omer Aplak <[email protected]> Co-authored-by: Salih Özdemir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: added
onUnauthorizedcallback to<CanAccess />component. This callback to be called whenuseCanreturns false.Test plan (required)
Self Check before Merge
Please check all items below before review.