Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nestjs-query): implement getApiUrl #5983

Merged
merged 6 commits into from
May 29, 2024

Conversation

issa012
Copy link
Contributor

@issa012 issa012 commented May 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

getApiUrl throws errors

What is the new behavior?

getApiUrl is implemented
fixes #5606

Notes for reviewers

Using workaround, since GraphQLClient's url field is private

@issa012 issa012 requested a review from a team as a code owner May 24, 2024 08:51
Copy link

changeset-bot bot commented May 24, 2024

🦋 Changeset detected

Latest commit: 64cbcd6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@refinedev/nestjs-query Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@aliemir aliemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @issa012 thank you for the contribution! Can you also add a changeset for it? You can check our Contributing Guide to learn how.

@alicanerdurmaz alicanerdurmaz changed the base branch from master to releases/june May 24, 2024 13:24
@BatuhanW BatuhanW requested a review from aliemir May 29, 2024 06:46
@BatuhanW BatuhanW merged commit 84adce3 into refinedev:releases/june May 29, 2024
14 checks passed
@aliemir aliemir mentioned this pull request May 29, 2024
BatuhanW pushed a commit that referenced this pull request Jun 4, 2024
BatuhanW pushed a commit that referenced this pull request Jun 4, 2024
@BatuhanW BatuhanW added this to the June Release milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: implement getApiUrl in @refinedev/nestjs-query
4 participants