-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): allow passing global app name and app icon #5993
feat(core): allow passing global app name and app icon #5993
Conversation
🦋 Changeset detectedLatest commit: e9b1113 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Passing run #11161 ↗︎Details:
Review all test suite changes for PR #5993 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icon: iconFromProps, | ||
text: textFromProps, | ||
wrapperStyles, | ||
}) => { | ||
const { | ||
title: { icon: defaultIcon, text: defaultText }, | ||
} = useRefineOptions(); | ||
const icon = | ||
typeof iconFromProps === "undefined" ? defaultIcon : iconFromProps; | ||
const text = | ||
typeof textFromProps === "undefined" ? defaultText : textFromProps; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can update tests for this and other UI library components.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
Changes
Added ability to pass global app name and icon values through
<Refine />
component'soptions
prop.Now
<Refine />
component acceptsoptions.title
prop that can be used to set app icon and app name globally. By default these values will be accessible throughuseRefineOptions
hook and will be used in<ThemedLayoutV2 />
and<AuthPage />
components of the UI packages.RK-634