-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(antd): useDrawerForm has unused props #6074
Merged
BatuhanW
merged 10 commits into
releases/july
from
fix/antd-useDrawerForm-has-unused-props
Jul 1, 2024
Merged
fix(antd): useDrawerForm has unused props #6074
BatuhanW
merged 10 commits into
releases/july
from
fix/antd-useDrawerForm-has-unused-props
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 494b150 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Passing run #11251 ↗︎Details:
Review all test suite changes for PR #6074 ↗︎ |
7bb0d6f
to
1330257
Compare
2bdcbad
to
68c60cd
Compare
omeraplak
reviewed
Jun 26, 2024
omeraplak
requested changes
Jun 26, 2024
omeraplak
reviewed
Jun 26, 2024
omeraplak
approved these changes
Jul 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
useDrawerForm
has the following props but they are not functional.What is the new behavior?
defaultFormValues
is implemented.submit
prop is removed fromuseDrawerForm
hook. Instead, you can useonFinish
prop to handle the form submission.https://refine.dev/docs/guides-concepts/forms/#modifying-data-before-submission
form
prop is removed fromuseDrawerForm
hook.The purpose of
useDrawerForm
is to create aform
instance. Because of thatform
instance cannot be passed as a prop.fixes #5727 #6082