Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(antd): useDrawerForm has unused props #6074

Merged
merged 10 commits into from
Jul 1, 2024

Conversation

alicanerdurmaz
Copy link
Member

@alicanerdurmaz alicanerdurmaz commented Jun 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

useDrawerForm has the following props but they are not functional.

  • defaultFormValues?: Store | (() => Promise | Store);
  • form?: any;
  • submit?: (formValues: Store) => any;

What is the new behavior?

  • defaultFormValues is implemented.
useForm({
  defaultFormValues: {
    title: "Hello World",
  },
});

fixes #5727 #6082

@alicanerdurmaz alicanerdurmaz requested a review from a team as a code owner June 24, 2024 07:45
Copy link

changeset-bot bot commented Jun 24, 2024

🦋 Changeset detected

Latest commit: 494b150

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@refinedev/antd Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alicanerdurmaz alicanerdurmaz added this to the July Release milestone Jun 24, 2024
Copy link

cypress bot commented Jun 24, 2024

Passing run #11251 ↗︎

0 169 26 0 Flakiness 0

Details:

Merge 494b150 into 4265ae2...
Project: refine Commit: afdaa14ebd ℹ️
Status: Passed Duration: 16:43 💡
Started: Jun 27, 2024 9:42 AM Ended: Jun 27, 2024 9:59 AM

Review all test suite changes for PR #6074 ↗︎

@alicanerdurmaz alicanerdurmaz marked this pull request as draft June 24, 2024 08:34
@alicanerdurmaz alicanerdurmaz force-pushed the fix/antd-useDrawerForm-has-unused-props branch from 7bb0d6f to 1330257 Compare June 25, 2024 07:54
@alicanerdurmaz alicanerdurmaz marked this pull request as ready for review June 25, 2024 07:57
@refine-bot refine-bot temporarily deployed to deploy-preview-website-6074 June 25, 2024 08:17 Inactive
@alicanerdurmaz alicanerdurmaz changed the base branch from master to releases/july June 26, 2024 07:03
@alicanerdurmaz alicanerdurmaz requested a review from a team as a code owner June 26, 2024 07:03
@alicanerdurmaz alicanerdurmaz force-pushed the fix/antd-useDrawerForm-has-unused-props branch from 2bdcbad to 68c60cd Compare June 26, 2024 07:09
@refine-bot refine-bot temporarily deployed to deploy-preview-website-6074 June 26, 2024 07:29 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-website-6074 June 26, 2024 14:42 Inactive
@alicanerdurmaz alicanerdurmaz requested a review from omeraplak June 26, 2024 15:18
@refine-bot refine-bot temporarily deployed to deploy-preview-website-6074 June 26, 2024 15:38 Inactive
@BatuhanW BatuhanW merged commit 311dcdc into releases/july Jul 1, 2024
45 checks passed
@BatuhanW BatuhanW deleted the fix/antd-useDrawerForm-has-unused-props branch July 1, 2024 12:49
@BatuhanW BatuhanW mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants