Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): rename useForm's mutationResult and queryResult to mutation and query #6164

Conversation

alicanerdurmaz
Copy link
Member

@alicanerdurmaz alicanerdurmaz commented Jul 22, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

useForm usage like this:

const { queryResult, mutationResult } = useForm()

What is the new behavior?

refactored to this for better readability

const { query, mutation } = useForm()

fixes #6163

Notes for reviewers

Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: 3d1c1eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@refinedev/core Minor
@refinedev/inferencer Patch
@refinedev/codemod Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 22, 2024

@github-actions github-actions bot temporarily deployed to deploy-preview-invoicer-6164/merge July 22, 2024 08:21 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-material-ui-6164/merge July 22, 2024 08:21 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-app-crm-6164/merge July 22, 2024 08:21 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-invoicer-6164/merge July 22, 2024 08:38 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-material-ui-6164/merge July 22, 2024 08:38 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-antd-6164/merge July 22, 2024 08:38 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-app-crm-6164/merge July 22, 2024 08:38 Inactive
@alicanerdurmaz alicanerdurmaz marked this pull request as ready for review July 22, 2024 08:50
@alicanerdurmaz alicanerdurmaz requested a review from a team as a code owner July 22, 2024 08:50
@alicanerdurmaz alicanerdurmaz changed the title feat(core): rename mutationResult and queryResult to mutation and query feat(core): rename useForm's mutationResult and queryResult to mutation and query Jul 22, 2024
@refine-bot refine-bot temporarily deployed to deploy-preview-website-6164 July 22, 2024 08:59 Inactive
Copy link

cypress bot commented Jul 22, 2024

Passing run #11353 ↗︎

0 381 37 0 Flakiness 0

Details:

Merge 9be8601 into ff97537...
Project: refine Commit: a97c062d5f ℹ️
Status: Passed Duration: 18:20 💡
Started: Jul 26, 2024 8:20 AM Ended: Jul 26, 2024 8:39 AM

Review all test suite changes for PR #6164 ↗︎

@alicanerdurmaz alicanerdurmaz requested a review from a team as a code owner July 22, 2024 15:49
@alicanerdurmaz alicanerdurmaz force-pushed the feat/RK-741-core-refactor-use-form-mutation-result-mutation-query-result-query branch from 4b500f6 to 93cd8ae Compare July 22, 2024 15:50
@github-actions github-actions bot temporarily deployed to deploy-preview-invoicer-6164/merge July 22, 2024 15:52 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-antd-6164/merge July 22, 2024 15:52 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-material-ui-6164/merge July 22, 2024 15:52 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-app-crm-6164/merge July 22, 2024 15:52 Inactive
…m-mutation-result-mutation-query-result-query
@github-actions github-actions bot temporarily deployed to deploy-preview-invoicer-6164/merge July 22, 2024 15:57 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-antd-6164/merge July 22, 2024 15:57 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-material-ui-6164/merge July 22, 2024 15:57 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-app-crm-6164/merge July 22, 2024 15:57 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-app-crm-6164/merge July 25, 2024 11:45 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-website-6164 July 25, 2024 12:05 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-invoicer-6164/merge July 25, 2024 13:04 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-antd-6164/merge July 25, 2024 13:04 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-material-ui-6164/merge July 25, 2024 13:04 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-app-crm-6164/merge July 25, 2024 13:04 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-website-6164 July 25, 2024 13:23 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-invoicer-6164/merge July 26, 2024 08:03 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-antd-6164/merge July 26, 2024 08:03 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-material-ui-6164/merge July 26, 2024 08:03 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-app-crm-6164/merge July 26, 2024 08:03 Inactive
@alicanerdurmaz alicanerdurmaz force-pushed the feat/RK-741-core-refactor-use-form-mutation-result-mutation-query-result-query branch from 8178b4b to bdf39b8 Compare July 26, 2024 08:09
@refine-bot refine-bot temporarily deployed to deploy-preview-website-6164 July 26, 2024 08:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Rename useForm's mutationResult and queryResult to mutation and query.
4 participants