Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): address feedbacks for documentation #6268

Merged
merged 14 commits into from
Aug 23, 2024

Conversation

BatuhanW
Copy link
Member

@BatuhanW BatuhanW commented Aug 19, 2024

Addressing user requests from documentation's inline feedback flow.

Screenshot 2024-08-19 at 15 45 30

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes (issue)

Notes for reviewers

@BatuhanW BatuhanW self-assigned this Aug 19, 2024
@BatuhanW BatuhanW requested review from a team as code owners August 19, 2024 12:46
Copy link

changeset-bot bot commented Aug 19, 2024

⚠️ No Changeset found

Latest commit: d17e70d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@refine-bot refine-bot temporarily deployed to deploy-preview-website-6268 August 19, 2024 13:10 Inactive
Copy link

cypress bot commented Aug 19, 2024



Test summary

382 1 37 0


Run details

Project refine
Status Failed
Commit 3d5c471 ℹ️
Started Aug 19, 2024 12:56 PM
Ended Aug 19, 2024 1:21 PM
Duration 25:21 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


Failures

cypress/e2e/table-material-ui-use-data-grid/all.cy.ts Failed
1 table-material-ui-use-data-grid > should work with sorter

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Member

@aliemir aliemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the packages (except for CHANGELOG.md files) should be referenced in a changeset or removed

@aliemir aliemir added this to the September Release milestone Aug 20, 2024
Copy link
Member

@omeraplak omeraplak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥰

@BatuhanW BatuhanW requested a review from aliemir August 23, 2024 09:18
@BatuhanW
Copy link
Member Author

Changes in the packages (except for CHANGELOG.md files) should be referenced in a changeset or removed

Removed changes in packages from this PR. Will create a separate one agains releases/september.

@BatuhanW BatuhanW merged commit 26d4065 into master Aug 23, 2024
10 checks passed
@BatuhanW BatuhanW deleted the RK-760-docs-fix-small-issues branch August 23, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants