-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mui): added loading spinner to <Create/>
, <Edit/>
and <Show/>
components.
#6271
Conversation
🦋 Changeset detectedLatest commit: e226f34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
<Create/>
, <Edit/>
and <Show/>
components.<Create/>
, <Edit/>
and <Show/>
components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anonymous961 thank you for your contribution! 🙏 I've sent a small commit to update the imports and updated the failed test snapshots.
We'll include this PR in our next release 🚀 🚀
Thanks @aliemir 🙏🏻 |
…/>` components. (refinedev#6271) (fixes refinedev#5668) Co-authored-by: Ali Emir Şen <[email protected]>
…/>` components. (refinedev#6271) (fixes refinedev#5668) Co-authored-by: Ali Emir Şen <[email protected]>
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
There is no loading spinner in the
<Create />
,<Edit />
, and<Show />
components in the@refinedev/mui
package. These components do not provide any visual feedback while loading or processing.What is the new behavior?
The
<Create />
,<Edit />
, and<Show />
components now display a loading spinner when theisLoading
prop is set totrue
.For the create page, the loading looks like this:
For the edit page, the loading looks like this:
For the show page, the loading looks like this:
fixes #5668
Notes for reviewers
I have used the same
<CircularProgress />
spinner as suggested in the issue discussion. I was considering making the loading behavior more conditional, either by showing the loading spinner or the contents, as it can be seen that there is content behind the spinner.