Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mui): added loading spinner to <Create/>, <Edit/> and <Show/> components. #6271

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

Anonymous961
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

There is no loading spinner in the <Create />, <Edit />, and <Show /> components in the @refinedev/mui package. These components do not provide any visual feedback while loading or processing.

What is the new behavior?

The <Create />, <Edit />, and <Show /> components now display a loading spinner when the isLoading prop is set to true.

For the create page, the loading looks like this:
image

For the edit page, the loading looks like this:
image

For the show page, the loading looks like this:
image

fixes #5668

Notes for reviewers

I have used the same <CircularProgress /> spinner as suggested in the issue discussion. I was considering making the loading behavior more conditional, either by showing the loading spinner or the contents, as it can be seen that there is content behind the spinner.

@Anonymous961 Anonymous961 requested a review from a team as a code owner August 19, 2024 19:17
Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: e226f34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@refinedev/mui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aliemir aliemir added this to the September Release milestone Aug 20, 2024
@aliemir aliemir changed the base branch from master to releases/september August 20, 2024 05:03
@aliemir aliemir requested a review from a team as a code owner August 20, 2024 05:03
@aliemir aliemir changed the title feat(mui): Added loading spinner to <Create/>, <Edit/> and <Show/> components. feat(mui): added loading spinner to <Create/>, <Edit/> and <Show/> components. Aug 20, 2024
Copy link
Member

@aliemir aliemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anonymous961 thank you for your contribution! 🙏 I've sent a small commit to update the imports and updated the failed test snapshots.

We'll include this PR in our next release 🚀 🚀

@aliemir aliemir merged commit 2b89fbd into refinedev:releases/september Aug 20, 2024
6 checks passed
@aliemir aliemir mentioned this pull request Aug 20, 2024
@Anonymous961
Copy link
Contributor Author

Thanks @aliemir 🙏🏻

emrecancorapci pushed a commit to emrecancorapci/refine that referenced this pull request Sep 4, 2024
emrecancorapci pushed a commit to emrecancorapci/refine that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <Show isLoading={true}> with Material UI doesn't show loading spinner
2 participants