GridView CME fix #491
Merged
GridView CME fix #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the linked issue a CME occurred at GridViewImpl#sort. It appeared like the backing list was being modified while a sort was happening. I noticed that the GridUpdatePacket runs on a different thread (had execute missing), so this change makes it so that GridUpdatePacket handling should happen on the same thread as the sort, and should avoid the CME happening in the first place. I wasn't able to test this due to the nature of the bug. See #480
…ended off-by-one If we start from 1 and increment by 10 we want 10, not 11.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #480