Release v2.0.0-milestone.3.4 #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main into develop branch
Transfer energy in wrench dismantling
To detect changes in a uniform way.
refactor: introduce listening energy storage
fix: changing side buttons doesn't work on Forge
refactor: remove generics for ResourceList and Storage
Only available in allowlist mode to avoid people trashing all their resources without realizing it and blaming Refined Storage. The void excess mode logic will only work when the resource was accepted through the filter, otherwise, a next storage is used instead. Requiring allowlist mode requires the player to think explicitly about the resources to be trashed.
feat: void excess mode
From the linked issue a CME occurred at GridViewImpl#sort. It appeared like the backing list was being modified while a sort was happening. I noticed that the GridUpdatePacket runs on a different thread (had execute missing), so this change makes it so that GridUpdatePacket handling should happen on the same thread as the sort, and should avoid the CME happening in the first place. I wasn't able to test this due to the nature of the bug. See #480
…ended off-by-one If we start from 1 and increment by 10 we want 10, not 11.
GridView CME fix
Carry On was initializing block entities twice. We had to: * Protect the event queue from running the update for the first erroneous initialization request. * Allow block entity removals without network, to avoid a crash when the block entity is replaced. The event queue hasn't run yet at that point so there's no network, so allow no networks on removal.
fix: problems moving network devices with Carry On mod
refactor: test hardening
fix: escape key not working on auto-selected grid search box
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @raoulvdberge!
This PR was created in response to a manual trigger of the release workflow here: https://github.com/refinedmods/refinedstorage2/actions/runs/8307465053.
Merging this PR will publish the release.