fix: resources not being used up correctly when there are missing items #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always have to add the resulting output resources to the internal storage, even if there are missing resources. If we would not do this, then, in the case of missing resources, it would re-calculate the same ingredient from scratch everytime and use way too much resources. However, if we always add resulting resources, even if there are missing items, we must still use up the yields from the recursive calculation. Otherwise, if we would not use up the yields from the recursive calculation, the crafting calculation would incorrectly use up resources from the internal storage for other ingredients. What is the difference between not adding the yields in case of missing resources and using up the recursive yields when there were missing resources? The difference lies in the fact that, when we do not add *any* yields, the crafting calculation would start from scratch everytime for each ingredient. Only using up what we needed in the first place from the recursive yield ensures that any _leftover_ yields can still be used up by other ingredients that happen to need the same resource. So, the difference lies in not having any yields at all versus still allowing access to the leftovers.
raoulvdberge
force-pushed
the
fix/NO-ISSUE/calculation-bug
branch
from
e581dec to
7cb2e3a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always have to add the resulting output
resources to the internal storage, even if there
are missing resources.
If we would not do this, then, in the case of
missing resources, it would re-calculate
the same ingredient from scratch everytime and
use way too much resources.
However, if we always add resulting resources,
even if there are missing items, we must still
use up the yields from the recursive calculation.
Otherwise, if we would not use up the yields
from the recursive calculation, the crafting
calculation would incorrectly use up resources
from the internal storage for other ingredients.
What is the difference between not adding the yields in case of missing resources and using up the recursive yields when there were missing resources?
The difference lies in the fact that, when we do not add any yields, the crafting calculation would start from scratch everytime for each ingredient.
Only using up what we needed in the first place from the recursive yield ensures that any leftover yields can still be used up by other ingredients that happen to need the same resource.
So, the difference lies in not having any yields at all versus still allowing access to the leftovers.