feat: support multiple resource types on a single external storage #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes #886 (flickering resources) by no longer listening to neighbor updates. This is no longer needed since changes are already detected independently. Previously, changes were only detected for the current resource type. This meant that detecting changes that happened via neighbor updates only worked if a block was replaced with another provider of the same resource type. To resolve this, support for multiple resource types was added. Additionally, the priority system was removed in favor of special casing the interface proxy.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #886 (flickering resources) by no longer listening to neighbor updates. This is no longer needed since changes are already detected independently.
Previously, changes were only detected for the current resource type. This meant that detecting changes that happened via neighbor updates only worked if a block was replaced with another provider of the same resource type. To resolve this, support for multiple resource types was added.
Additionally, the priority system was removed in favor of special casing the interface proxy.