Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stateful benchmarks #4764

Merged
merged 4 commits into from
Feb 12, 2025
Merged

add stateful benchmarks #4764

merged 4 commits into from
Feb 12, 2025

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Feb 6, 2025

No description provided.

Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #4764 will not alter performance

Comparing lendemor/add_stateful_benchmarks (e647f5f) with main (b3b79a6)

Summary

✅ 8 untouched benchmarks
🆕 4 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_compile_page[_stateful_page] N/A 16.9 ms N/A
🆕 test_compile_stateful[_stateful_page] N/A 472.2 µs N/A
🆕 test_get_all_imports[_stateful_page] N/A 4.2 ms N/A
🆕 test_evaluate_page[_stateful_page] N/A 23.9 ms N/A

@Lendemor Lendemor requested a review from masenf February 6, 2025 18:13
@adhami3310
Copy link
Member

It seems the tests are very small for this, do we want to make it slightly larger? could be more deeply nested or such

@adhami3310 adhami3310 merged commit a31301c into main Feb 12, 2025
39 checks passed
@adhami3310 adhami3310 deleted the lendemor/add_stateful_benchmarks branch February 12, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants