-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to tailwind 4 #4766
base: main
Are you sure you want to change the base?
upgrade to tailwind 4 #4766
Conversation
CodSpeed Performance ReportMerging #4766 will not alter performanceComparing Summary
|
@carlosabadia i couldn't figure out how to fix reflex-web here. feel free to try |
i tried poking around with these changes diff --git a/assets/tailwind-theme.css b/assets/tailwind-theme.css
index 92cfba50..a0f54364 100644
--- a/assets/tailwind-theme.css
+++ b/assets/tailwind-theme.css
@@ -1,15 +1,29 @@
@tailwind base;
@tailwind components;
@tailwind utilities;
-
-:root {
- --font-instrument-sans: 'Instrument Sans', sans-serif;
- --font-source-code-pro: 'Source Code Pro', monospace;
- --font-jetbrains: "JetBrains Mono", monospace;
- color-scheme: light dark;
+@reference '../styles/tailwind.css'
+
+:root {}
+
+/* in tw4, need to define apply-able classes as @utility */
+@utility font-small {
+ font-family: var(--font-instrument-sans);
+ font-size: 0.9rem;
+ font-style: normal;
+ font-weight: 500;
+ line-height: 1.25rem;
+ /* 142.857% */
+ letter-spacing: -0.01094rem;
}
@layer components {
+ :root {
+ --font-instrument-sans: 'Instrument Sans', sans-serif;
+ --font-source-code-pro: 'Source Code Pro', monospace;
+ --font-jetbrains: "JetBrains Mono", monospace;
+ color-scheme: light dark;
+ }
+
.font-instrument-sans {
font-family: var(--font-instrument-sans);
}
@@ -203,13 +217,7 @@
}
.font-small {
- font-family: var(--font-instrument-sans);
- font-size: 0.9rem;
- font-style: normal;
- font-weight: 500;
- line-height: 1.25rem;
- /* 142.857% */
- letter-spacing: -0.01094rem;
+ @apply font-small;
}
.font-md { and while that got things to compile, the side didn't look the same. desktop-only/mobile-only was busted font sizes were different i think to make it work, we need to port our relatively complex tailwind config over to the v4 config format. |
I'll create a ticket to update it. However, will previous Tailwind versions still be available for use after this is merged? |
should we add an option to choose what version of tailwind to use ? i'm conflicted |
It can be changed in The v4 wont work though, without the changes in this PR |
No description provided.