raise error when passing a str(var) #4769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4769 will not alter performanceComparing Summary
|
Lendemor
reviewed
Feb 7, 2025
masenf
reviewed
Feb 7, 2025
| T = TypeVar("T") | ||
|
|
||
|
|
||
| def once(f: Callable[[], T]) -> Callable[[], T]: |
There was a problem hiding this comment.
could we use the new global var cache for this so we have some control over evicting the values?
There was a problem hiding this comment.
we could, but i think we should keep this one away from global var cache until we improve that one (also unsure if we want to mix var with not vars)
Lendemor
requested changes
Feb 10, 2025
Co-authored-by: Thomas Brandého <[email protected]>
Co-authored-by: Thomas Brandého <[email protected]>
Lendemor
approved these changes
Feb 11, 2025
adhami3310
deleted the
khaleel/eng-4609-component-should-throw-warning-if-stringified-var-is-passed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.