-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include React 16 in peer dependencies. #543
base: master
Are you sure you want to change the base?
Conversation
I don't understand why this build is failing, it builds fine locally. My only guess is that this build uses npm Thoughts? |
Any update on this? Would be great to have this merged! Let me know if I can help in any way |
It looks like the build is failing because the React version is specified as 15 in the .travis.yml, but react-dom is installing 16.2.0 |
Given the current state of the tests, the easiest solution here is to modify the |
Interesting. If they're using |
Also the npm WARN peerDependencies
React needs to be moved from |
@AndrewSouthpaw I believe createClass is only used for the component tests. |
FWIW, I had modified the travis build to install react-dom at the specified version in #545 and received a log4js error during build, so I think that is also likely to be an impediment to a merge. |
Ah, that makes sense. |
You can go ahead and use https://github.com/ied3vil/reflux-react-16 Also, if you feel you want to improve, you can PR |
Is there any update on this? I too would like to update the React version but not sure if it will break anything. |
Just use the repo i posted above your comment, we have been using it in production with React 16.x without issues for a year |
Based on #537, and from my own testing, the latest Reflux works fine with React 16. This PR updates the peer dependency to include React 16.