Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: purge nested duplicate context for node data #552

Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix: purge nested duplicate context for node data #552

merged 2 commits into from
Mar 5, 2025

Conversation

mrcfps
Copy link
Contributor

@mrcfps mrcfps commented Mar 5, 2025 •
edited
Loading

Summary

  • Purge nested duplicate context when adding new nodes
  • Automatically remove recursive contextItems data for existing canvases
  • Add missing runtimeConfig for skill node preview

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Impact Areas

Please check the areas this PR affects:

  • Multi-threaded Dialogues
  • AI-Powered Capabilities (Web Search, Knowledge Base Search, Question Recommendations)
  • Context Memory & References
  • Knowledge Base Integration & RAG
  • Quotes & Citations
  • AI Document Editing & WYSIWYG
  • Free-form Canvas Interface
  • Other

Screenshots/Videos

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Refly Documentation
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

mrcfps added 2 commits March 5, 2025 15:34
@mrcfps
fix(canvas): purge context items to avoid recursive duplicate content
f6b27b2 
- Introduce `runtimeConfig` in skill node metadata
- Add `setRuntimeConfig` method to update runtime configuration
- Implement context item purging utility to clean metadata
- Update context panel and node data management to handle runtime configs
@mrcfps
fix(canvas): safely fix context items for existing canvases
2c53ac1 
- Add null/non-array check in `purgeContextItems` utility
- Modify `syncNodesToYDoc` to purge context items before synchronization
- Prevent potential errors when syncing nodes with invalid context item data
@mrcfps mrcfps changed the title fix: purge recursive duplicate context for node data fix: purge nested duplicate context for node data Mar 5, 2025
@mrcfps mrcfps merged commit 70eba7a into main Mar 5, 2025
2 of 3 checks passed
@mrcfps mrcfps deleted the fix/recursive-context branch March 5, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pftom pftom pftom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrcfps @pftom