Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): properly handle edges cases for sharing and duplication #554

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

mrcfps
Copy link
Contributor

@mrcfps mrcfps commented Mar 5, 2025

Summary

  • Add 404 ignore option for Elasticsearch resource and document retrieval
  • Add null check for storage key in file publishing methods
  • Prevent potential errors when processing missing or empty storage keys

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Impact Areas

Please check the areas this PR affects:

  • Multi-threaded Dialogues
  • AI-Powered Capabilities (Web Search, Knowledge Base Search, Question Recommendations)
  • Context Memory & References
  • Knowledge Base Integration & RAG
  • Quotes & Citations
  • AI Document Editing & WYSIWYG
  • Free-form Canvas Interface
  • Other

Screenshots/Videos

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Refly Documentation
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

- Add 404 ignore option for Elasticsearch resource and document retrieval
- Add null check for storage key in file publishing methods
- Prevent potential errors when processing missing or empty storage keys
@mrcfps mrcfps merged commit 009ede9 into main Mar 5, 2025
3 of 5 checks passed
@mrcfps mrcfps deleted the fix/share-publish-errors branch March 5, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants