[feat] Update archspec and topology file call for CPU model name
#3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I test this patch? |
|
test this patch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3185 +/- ##
========================================
Coverage 86.67% 86.67%
========================================
Files 61 61
Lines 12139 12139
========================================
Hits 10521 10521
Misses 1618 1618 ☔ View full report in Codecov by Sentry. |
jack-morrison
changed the title
archspec and topology file call for CPU model namearchspec and topology file call for CPU model name
teojgo
previously requested changes
May 7, 2024
jack-morrison
force-pushed
the
bump-archspec
branch
from
5e17023 to
2a341fd
Compare
Done -- thanks for the pointer @teojgo 😃 |
vkarak
requested changes
May 7, 2024
Co-authored-by: Vasileios Karakasis <[email protected]>
vkarak
approved these changes
May 7, 2024
createyourpersonalaccount
pushed a commit
to createyourpersonalaccount/reframe
that referenced
this pull request
May 15, 2024
…eframe-hpc#3185) * Update archspec and topology file call for cpu model name * Update setup.cfg Co-authored-by: Vasileios Karakasis <[email protected]> --------- Co-authored-by: Vasileios Karakasis <[email protected]>
teojgo
pushed a commit
to teojgo/reframe
that referenced
this pull request
May 17, 2024
…eframe-hpc#3185) * Update archspec and topology file call for cpu model name * Update setup.cfg Co-authored-by: Vasileios Karakasis <[email protected]> --------- Co-authored-by: Vasileios Karakasis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #3107 and #3132 to adopt the new function from archspec v0.2.4 returning a CPU brand string.