[feat] New configuration parameter for specifying commands to install reframe remotely for topology detection #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Blanca-Fuentes, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2024-10-29 16:58:01 UTC |
ekouts
reviewed
Oct 8, 2024
There was a problem hiding this comment.
For me this is a very good start. It would be good to have some unittests that check the basic functionality f the feature.
Some things that maybe we still need to discuss:
- Should we copy the reframe directory in the custom command case? I think not, as long as we don't have a use case for it.
- Do we give the option to the user to add commands pre/post in the current scripts (bootstrap/pip)?
ekouts
reviewed
Oct 10, 2024
ekouts
reviewed
Oct 10, 2024
ekouts
reviewed
Oct 10, 2024
ekouts
reviewed
Oct 10, 2024
vkarak
requested changes
Oct 17, 2024
There was a problem hiding this comment.
I like the idea of allowing users to specify the exact commands to run, but I would rather restrict that to the installation commands only. The reframe --detect-host-topology=topo.json should be added always by the framework.
As a result we should rather call the configuration variable as remote_install.
vkarak
requested changes
Oct 23, 2024
This was referenced Oct 29, 2024
vkarak
approved these changes
Oct 29, 2024
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option of specifying custom commands to install reframe in a remote partition for the topology auto-detection.
Previously, a clone of reframe was created running bootstrap or pip in order to launch reframe with auto-detect option.
Now, a list of custom commands can be specified to install reframe through
general:remote_installto avoid creating a reframe clone withpipor running.\bootstrap.sh.The
reframe --detect-host-topology=topo.jsonis run after the commands for the remote reframe installation.Closes #2292.
Closes #2690.
Closes #2979 .