Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prehook #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prehook #15

wants to merge 2 commits into from
+55 −2

Conversation

Quramy
Copy link
Member

@Quramy Quramy commented Nov 16, 2017

close #14

@Quramy Quramy requested a review from bokuweb November 16, 2017 06:03
@Quramy
Copy link
Member Author

Quramy commented Nov 16, 2017

  • Is the option name preprocess semantic enough?
  • Is it easy to integrate to reg-cli ?

bokuweb
bokuweb approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@bokuweb bokuweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Is the option name preprocess semantic enough?

Is preProcessHook verbose as another idea?

Is it easy to integrate to reg-cli ?

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bokuweb bokuweb bokuweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to callback additional diff-engine with decoded images data
2 participants
@Quramy @bokuweb