Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Upgdate CI Puppeteer to latest #901

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't stop wait page navigation
  • Loading branch information
Quramy committed Sep 3, 2024
commit a681bff6638cd277330d3a193a6b2c42282c7005
19 changes: 11 additions & 8 deletions packages/storycrawler/src/browser/stories-browser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,17 @@ export class StoriesBrowser extends BaseBrowser {
this.logger.debug('Wait for stories definition.');
await this.page.goto(this.connection.url);
let stories: Story[] | null = null;
await this.page
.goto(this.connection.url + '/iframe.html?selectedKind=story-crawler-kind&selectedStory=story-crawler-story', {
timeout: 60_000,
waitUntil: 'domcontentloaded',
})
.catch(() => {
this.logger.warn('Timeout to open Storybook preview iframe.');
});
// await this.page
// .goto(this.connection.url + '/iframe.html?selectedKind=story-crawler-kind&selectedStory=story-crawler-story', {
// timeout: 60_000,
// waitUntil: 'domcontentloaded',
// })
// .catch(() => {
// this.logger.warn('Timeout to open Storybook preview iframe.');
// });
this.page.goto(
this.connection.url + '/iframe.html?selectedKind=story-crawler-kind&selectedStory=story-crawler-story',
);
await this.page.waitForFunction(
() =>
(window as ExposedWindow).__STORYBOOK_CLIENT_API__ ||
Expand Down
Loading