Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contact page #518

Merged
merged 7 commits into from
Mar 10, 2021
Merged

Update contact page #518

merged 7 commits into from
Mar 10, 2021

Conversation

blushi
Copy link
Member

@blushi blushi commented Mar 8, 2021

closes: #472

@blushi
Copy link
Member Author

blushi commented Mar 9, 2021

@mhagel @haveanicedavid I have also updated the snapshots tests setup as part of this PR (the tests were failing, the main issue was due to the use of storybook-addon-material-ui with our setup, same as described here: react-theming/storybook-addon-material-ui#102)

mhagel
mhagel approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@mhagel mhagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blushi blushi merged commit 85a30f0 into master Mar 10, 2021
@blushi blushi deleted the marie/472-contact branch October 19, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhagel mhagel mhagel approved these changes

@erikalogie erikalogie Awaiting requested review from erikalogie

@haveanicedavid haveanicedavid Awaiting requested review from haveanicedavid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes to contact form to have more explicit options for different users
2 participants
@blushi @mhagel