Don't send a PR for arch migrations if build_platform is in conda-foge.yml #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
requested changes
Jun 29, 2024
Comment on lines
-189
to
-191
| return muid in _sanitized_muids( | ||
| attrs.get("pr_info", {}).get("PRed", []), | ||
| ) |
There was a problem hiding this comment.
I am confused as to why we no longer need this block of code any more. The call to super().filter above does not check if the PR has already been made. This change will force the bot to reissue arch PRs to feedstocks if they merged an arch PR but then subsequently removed arch builds for w/e reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ge.yml