Integration tests #3417
Open
Integration tests #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/tests.yml # autotick-bot/install_bot_code.sh # conda-lock.yml # conda_forge_tick/migration_runner.py # conda_forge_tick/provide_source_code.py # conda_forge_tick/rerender_feedstock.py # conda_forge_tick/solver_checks.py # conda_forge_tick/utils.py # environment.yml # tests/test_container_tasks.py
This reverts commit 973d95c. did not solve the issue
to make it consistent with the env variable naming
ytausch
commented
Jan 14, 2025
ytausch
commented
Jan 14, 2025
|
The integration tests now run again (see the PR in my fork). @beckermr, I'd appreciate it if we could prioritize this PR. It would help to establish more trust in future code changes, and it's potentially also very work-intensive to fix the tests again after a significant amount of code changes have been committed to main. The first step would be the proxy mode PR I've linked above. |
|
Thanks for reviewing conda-forge/conda-forge-feedstock-ops#34! I removed the temporary workaround for its functionality in a72eb37. How should we proceed with setting up the token? |
pavelzw
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds integration tests to the autotickbot, interacting with a real GitHub test environment. Closes #261 (more details there). This is a "minimal breakthrough" PR, only adding one test for version updates (using the pydantic-feedstock as an example).
Implementation is finished.
In this demo PR in my fork the integration tests actually run (needs token setup): ytausch#2
I've added a
CODEOWNERSfile to automatically request reviews from me if anything related to the tests change. On this occasion, I've also added a selection of other files where I am the main contributor. Hope you're fine with this!@pavelzw
Checklist:
Cross-refs, links to issues, etc:
run_container_operationconda-forge/conda-forge-feedstock-ops#34