-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle run_constrained and constraints in run_exports #31
Conversation
@@ -1069,12 +1087,21 @@ def _is_recipe_solvable_on_platform( | |||
if m.noarch or m.noarch_python: | |||
run_req = list(set(run_req) | host_rx["noarch"]) | |||
else: | |||
run_req = list(set(run_req) | host_rx["weak"]) | |||
run_req = list(set(run_req) | host_rx["weak"] | host_rx["strong"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this line is a bug fix. Thanks for catching!
@jaimergp do you understand the solver errors here? I don't get the error that arrow-cpp does not exist. |
Hm, I haven't used that method. What about |
I don't see why that makes sense. Care to explain more? |
and check that constraints don't get installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding pins as I understand them won't work. Sometimes people use run constraints to versions of packages that do not exist. I assume the solver will try to install the pins and this will create false negatives.
I opened mamba-org/mamba#3293 because |
Ohhhhh wow. I think add_pin <-> add_constraint need to have their names swapped. If add_pin does not install, then we're fine. |
@beckermr I don't know if it's a terminology problem or what, but that's what I expected, too. But it's not how it behaves, despite explicitly stating it should, I think. |
If this passes, I think we'll want a tighter pin on libmambapy in the feedstock so that if this bug gets fixed, things still work. |
2.0 is in beta already which appears to significantly change the Python API, so |
We'll need to patch old release of this anyways then. |
I added a few tests that run in a matter of seconds for me, but CI runtime has more than doubled in this PR. I don't know if that's a fluke or a consequence of the pinning changes. |
It is probably related, but TBH we don't get a choice on these things. The solver takes how long the solver takes. I am going to merge and we can add options to turn this off later if we need it. |
follow-up to #30, this actually implements applications of constraints to the solve