Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build API documentation #1219

Closed
wants to merge 1 commit into from
Closed

Conversation

tinatn29
Copy link
Contributor

@tinatn29 tinatn29 commented Dec 13, 2024

built docs with auto_api.py per cookiecutting instructions (files in doc/source were modified) + fixed typos flagged by codespell.

Besides fixing the typos, I didn't make any tweaks after auto_api did its thing, so let me know if any of the files modified should be different...

did this build one of the two docs (or both) that @bobleesj mentioned in #1218?

Copy link

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (054b004) to head (45baf38).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1219   +/-   ##
=======================================
  Coverage   79.64%   79.64%           
=======================================
  Files          17       17           
  Lines        1366     1366           
=======================================
  Hits         1088     1088           
  Misses        278      278           

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this file added?

@@ -45,7 +45,7 @@ The following lists key names mapped to its type and meaning for each entry.
:notes: list, any notes about the kickoff, optional
:status: string, status of the kickoff. Allowed values are {', '.join(PROJECTUM_STATI)}, optional

Allowed values:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure the cause of these extra spaces provided throuhgout. I think this PR should only fix along doc/source/api/... right?

Copy link
Contributor

@bobleesj bobleesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a preliminary look. Please check my in-line comments. @tinatn29

For this PR, since we are modifying a lot, I think it would be safer for us to just do api_doc only? Also since there is one commit, I can't really track what manual modifications have been made.

@tinatn29 tinatn29 closed this Dec 13, 2024
@tinatn29
Copy link
Contributor Author

tinatn29 commented Dec 13, 2024

closed without merging -- will redo this PR to separate commits and make sure auto_api is doing the right thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants