Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: CSPlayer methods enhancement #862

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

dystopm
Copy link
Contributor

@dystopm dystopm commented Sep 12, 2023

  • Added C4 drop when changing from CT/T to SPEC
    • Deleted m_bHasC4 assignation to false due to code redundancy in RemoveAllItems
  • Changed return types of DropShield and DropPlayerItem to CBaseEntity to retrieve created entity index.

This requieres to update API version and submodules like ReAPI. (actually done)

EDIT: this partially grabs #699 changes in a segmented/detailed way

@StevenKal
Copy link
Contributor

StevenKal commented Sep 12, 2023

I am not sure (must test), but also if we use "CCSPlayer::JoinTeam" to transfer from T/CT to SPECTATOR when the spawn protection icon ("StatusIcon" with ""suithelmet_full"") is still blinking, the icon keeps blinking while it should not, so might need to add the reset inside the "SPECTATOR" case, or elsewhere.

@s1lentq : Please close my PR #699 as I will not update it.

@s1lentq s1lentq merged commit 8a52b7e into rehlds:master Sep 28, 2023
4 checks passed
@dystopm dystopm deleted the csplayer_api_upgrade branch October 11, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants