Update CladeTime tree_as_of and sequence_as_of date handling #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsweger
commented
Oct 9, 2024
| return self._sequence_as_of | ||
|
|
||
| @sequence_as_of.setter | ||
| def sequence_as_of(self, date) -> None: |
There was a problem hiding this comment.
The logic for setting sequence_as_of and tree_as_of default values is no longer the same, so created a setter for each of these properties.
elray1
requested changes
Oct 10, 2024
elray1
reviewed
Oct 10, 2024
src/cladetime/cladetime.py
Outdated
| if date is None: | ||
| sequence_as_of = datetime.now() | ||
| sequence_as_of = self._validate_as_of_date(date) | ||
| utc_now = datetime.now().replace(tzinfo=timezone.utc) |
There was a problem hiding this comment.
might this actually end up pointing to a past time?
>>> now = datetime.now()
>>> utc_now = now.replace(tzinfo=timezone.utc)
>>> # Create a timezone object for Eastern Time (UTC-4)
>>> eastern_tz = timezone(timedelta(hours=-4))
>>> eastern_now = now.replace(tzinfo=eastern_tz)
>>>
>>> now
datetime.datetime(2024, 10, 10, 13, 50, 2, 440530)
>>> utc_now
datetime.datetime(2024, 10, 10, 13, 50, 2, 440530, tzinfo=datetime.timezone.utc)
>>> eastern_now
datetime.datetime(2024, 10, 10, 13, 50, 2, 440530, tzinfo=datetime.timezone(datetime.timedelta(days=-1, seconds=72000)))
>>>
>>> eastern_now > utc_now
True
It seems like replace here does not calculate the time corresponding to "now" in UTC...
There was a problem hiding this comment.
Maybe the operation we want is
utc_now = datetime.now(tz=timezone.utc)
elray1
reviewed
Oct 10, 2024
src/cladetime/cladetime.py
Outdated
| tree_as_of = self.sequence_as_of | ||
| else: | ||
| tree_as_of = self._validate_as_of_date(date) | ||
| utc_now = datetime.now().replace(tzinfo=timezone.utc) |
There was a problem hiding this comment.
flagging same discussion as above
Co-authored-by: Evan Ray <[email protected]>
elray1
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #33
See the linked issue for details. Essentially, this PR modifies two cases when setting
sequence_as_ofandtree_as_ofdates forCladeTimeobjects:if no tree_as_of parameter is specified when instantiating CladeTime, tree_as_of should default to the sequence_as_of value.
if either tree_as_of or sequence_as_of is a future date, CladeTime instantiation should give a warning and use the current datetime value instead.