Add "as_of" columns to oracle output target data #300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #296
Add
sequence_as_of
andtree_as_of
columns to the oracle output target data files. We didn't talk about the latter in the call earlier this week, but if we're adding as a hedge against out-of-order data creation, I think it makes sense to have both.This PR also fixes a few issues I noticed when making the above updates:
get_target_data.py
wasn't listed insrc/README.md
get_target_data.py
had old help textEdited to add some terminal output from a local test of the updated file: