chore: add full record of visited_pcs to support starknet-replay
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eagle941
force-pushed
the
add_visited_pcs_raw
branch
from
d202874
to
e410118
Compare
Eagle941
changed the title
visited_pcs to support starknet-replayvisited_pcs to support starknet-replay
Eagle941
changed the title
visited_pcs to support starknet-replayvisited_pcs to support starknet-replay
`CachedState`.
Eagle941
force-pushed
the
add_visited_pcs_raw
branch
from
e410118
to
5d79056
Compare
iamrecursion
reviewed
Aug 9, 2024
There was a problem hiding this comment.
At first look this seems reasonable, barring the name for the feature. Have you run benchmarking to ensure that nothing has changed in terms of performance without your new feature enabled? We need to ensure that this does not introduce any performance regressions to the non-feature-enabled use-case, and it seemed to me like some code has indeed changed in those paths.
`vector_of_visited_program_counters`.
Eagle941
force-pushed
the
add_visited_pcs_raw
branch
from
4110892
to
d6e2185
Compare
`blockifier/transaction_executor.rs`.
Eagle941
force-pushed
the
add_visited_pcs_raw
branch
from
43a1576
to
f8f105c
Compare
Eagle941
force-pushed
the
add_visited_pcs_raw
branch
from
f8f105c
to
3062b0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature
full_visited_pcsto record the full vector of visited pcs instead of just theHashSetinCachedState