Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node-pty to fix build errors #15

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Upgrade node-pty to fix build errors #15

merged 1 commit into from
Sep 3, 2020

Conversation

MatthewScholefield
Copy link
Contributor

@MatthewScholefield MatthewScholefield commented Sep 3, 2020

This fixes #14 and possibly #13.

Can install from my fork with:

# For yarn:
yarn global add "https://github.com/MatthewScholefield/rekit-studio#patch-1"

# For npm (I think):
npm install -g "https://github.com/MatthewScholefield/rekit-studio#patch-1"

@supnate supnate merged commit ddfd895 into rekit:master Sep 3, 2020
@supnate
Copy link
Collaborator

supnate commented Sep 3, 2020

Thanks @MatthewScholefield , I will publish a new version including the update soon.

@MatthewScholefield
Copy link
Contributor Author

MatthewScholefield commented Sep 3, 2020

@supnate Thanks for merging.

Edit: Updated with the following:

It still fails with #9, but I think this is just because I'm trying to install directly from my fork in git. It looks like it needs to be manually packaged for the direct installation to work.

@MatthewScholefield MatthewScholefield deleted the patch-1 branch September 3, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gyp ERR! build errors when trying to install rekit-studio.
2 participants